Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docker from the provision OperatingSystemConfig #221

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kostov6
Copy link
Contributor

@Kostov6 Kostov6 commented Dec 16, 2024

How to categorize this PR?

/area os
/kind cleanup
/os garden-linux

What this PR does / why we need it:
This PR removes executions of docker commands in the init OperatingSystemConfig.

From Gardener side, the docker binary is no longer used/required on a Shoot Node: gardener/gardener#4673.
From gardeninux OS side, [email protected]+ no longer includes the docker binary unit in the OS.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

Release note:

The os-gardenlinux extension does no longer enable and restart the `docker` unit as part of the init OperatingSystemConfig. Gardener and Kubernetes does no longer support `docker` as CRI. Gardener does no longer rely on the `docker` binary to be present on the Nodes. [[email protected]+](https://github.com/gardenlinux/gardenlinux/releases/tag/1443.1) no longer includes the `docker` binary unit in the OS.
The os-gardenlinux extension does no longer enable and restart the `docker` unit as part of the init OperatingSystemConfig. If you, as end user, rely on the docker unit to be enabled by default on the Node, this is a breaking change for you. In such case, you would need to enable the docker unit on your own.
Pay attention that [[email protected]+](https://github.com/gardenlinux/gardenlinux/releases/tag/1443.1) no longer includes the `docker` binary unit in the OS.

Co-authored-by: Vladimir Nachev <[email protected]>
Co-authored-by: Ismail Alidzhikov <[email protected]>
@gardener-robot gardener-robot added area/os Operation system related kind/cleanup Something that is not needed anymore and can be cleaned up os/garden-linux Related to Garden Linux OS needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Dec 16, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 16, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 16, 2024
@ialidzhikov ialidzhikov changed the title Remove docker from provisioning OperatingSystemConfig Remove docker from the provision OperatingSystemConfig Dec 17, 2024
@Kostov6 Kostov6 marked this pull request as ready for review December 17, 2024 09:17
@Kostov6 Kostov6 requested review from a team as code owners December 17, 2024 09:17
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 17, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 17, 2024
@ialidzhikov
Copy link
Member

We had a sync with @vpnachev and @Kostov6 to discuss if such change might be a breaking one for end users that make use of the docker binary/unit on the Node outside of Kubernetes (not recommended). The breaking change would be end user to rely on the docker unit to be enabled for gardenlinux versions that still contain the unit/binary.

To be on the safe side, we decided to hold with the change until end of February when old gardenlinux version which still contain docker such as [email protected] and [email protected] reach EoL.

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/os Operation system related kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) os/garden-linux Related to Garden Linux OS reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants