Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop internal version of nodeagent.config.gardener.cloud API #11097

Merged
merged 5 commits into from
Jan 3, 2025

Conversation

timebertt
Copy link
Member

How to categorize this PR?

/area dev-productivity
/kind cleanup

What this PR does / why we need it:

This PR drops the internal version of the nodeagent.config.gardener.cloud API.

Which issue(s) this PR fixes:
Part of #11043

Special notes for your reviewer:

Release note:

NONE

@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) kind/cleanup Something that is not needed anymore and can be cleaned up labels Jan 2, 2025
@gardener-prow gardener-prow bot requested review from marc1404 and plkokanov January 2, 2025 09:16
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 2, 2025
@timebertt
Copy link
Member Author

/retest

Copy link
Contributor

@shafeeqes shafeeqes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2025
Copy link
Contributor

gardener-prow bot commented Jan 3, 2025

LGTM label has been added.

Git tree hash: a8b1edbe53d18ad4650326a7f231c0234499065a

@timebertt
Copy link
Member Author

/approve

Copy link
Contributor

gardener-prow bot commented Jan 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timebertt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2025
@LucaBernstein
Copy link
Member

/retest

@gardener-prow gardener-prow bot merged commit ed250f8 into gardener:master Jan 3, 2025
19 checks passed
@timebertt timebertt deleted the config-apis-node-agent branch January 4, 2025 09:25
majst01 pushed a commit to metal-stack/gardener that referenced this pull request Jan 4, 2025
…ner#11097)

* Move API validation

* Drop internal API version

* Adapt entrypoint

* Adapt imports

* Update skaffold dependencies
RadaBDimitrova pushed a commit to RadaBDimitrova/gardener that referenced this pull request Jan 15, 2025
…ner#11097)

* Move API validation

* Drop internal API version

* Adapt entrypoint

* Adapt imports

* Update skaffold dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants