-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add Context
to Run
method of the manager
#757
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@afritzler Thank you for your contribution. |
14c7c65
to
d3addec
Compare
Context
to Run
method of the managerContext
to Run
method of the manager
31626b6
to
6b51e30
Compare
6b51e30
to
82ed5c5
Compare
82ed5c5
to
c48450c
Compare
efea570
to
df92a1b
Compare
df92a1b
to
be98785
Compare
be98785
to
6913520
Compare
6913520
to
eb2f245
Compare
eb2f245
to
0d2988f
Compare
0d2988f
to
00bbb2c
Compare
00bbb2c
to
1e723d4
Compare
@afritzler You need rebase this pull request with latest master branch. Please check. |
@afritzler we have a planned refactoring for MCM where we will add signal handling. Unless you think that there is a blocker in consuming/testing MCM due to this issue, we would like to ask you to close this PR , in favour the aforementioned issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs/changes
Needs (more) changes
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/rebase
Needs git rebase
needs/review
Needs review
needs/second-opinion
Needs second review by someone else
size/xl
Size of pull request is huge (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Motivation
Running the MCM as a provider makes it currently hard to test because there is no clean way to terminate a running MCM instance via a signal/context cancel.
Proposed change
This PR introduces a context handler to the
run()
method of the manager. You can now pass a context e.g.SignalHandler
This is a BREAKING change for all provider implementer as they now have to pass on a context.
Additionally a few potential
nil
pointer derefs have been fixed an a couple of linting issues addressed.Release note: