Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle multibyte characters in scenario label correctly #1592

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KeitaHiguchi
Copy link

Problem

Scenario labels containing multibyte characters (e.g., Japanese, Chinese) were not processed correctly.

For example, when defining a scenario like:

{
  "scenarios": [
    {
      "label": "BackstopJS ホームページ",
      ** other configurations **
    },
    {
      "label": "BackstopJS テストページ",
      ** other configurations **
    }
  ]
}

Multibyte characters are ignored in the generated capture filenames,
causing both scenarios to generate the same filename, making it impossible to differentiate between test results.

Solution

  • Fixed the encoding issue when handling scenario labels to ensure multibyte characters are properly retained in capture filenames.

Fixed an issue where BackstopJS failed to process scenario labels containing multibyte characters (e.g., Japanese, Chinese).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant