fixed more bugs with deleted nodes

gatewayapps · Jun 23, 2021 · 9b742c0 · 9b742c0
1 parent fb52142
commit 9b742c0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@gatewayapps/ims-hub-services",
-  "version": "0.6.2",
+  "version": "0.6.3",
   "main": "./dist/index.js",
   "publishConfig": {
     "access": "public"

diff --git a/src/hubCache.ts b/src/hubCache.ts
@@ -43,6 +43,10 @@ export class HubCache {
     node: ICachedNode,
     excludedNodeIds: number[]
   ): number[] {
+    if (!node) {
+      return []
+    }
+
     const result = node.descendantIds!.filter(
       (id) =>
         // Ensure none of this descendants ancestors appear in the exclusion list
@@ -67,7 +71,9 @@ export class HubCache {
     treeId: number
   ): number[][] {
     const distinctRoots = this.removeOverlappingRoots(rootNodeIds)
-    const finalRoots = distinctRoots.filter((rootId) => !excludedNodeIds.includes(rootId))
+    const finalRoots = distinctRoots.filter(
+      (rootId) => !excludedNodeIds.includes(rootId) && this.nodeHashMap[rootId]
+    )
 
     const validDescendantArrays = finalRoots.map((root) =>
       this.applyExclusionsToNodeDescendants(this.nodeHashMap[root], excludedNodeIds)