fix: read weather station by its id

gaveshalabs · Jan 18, 2024 · 499c4dd · 499c4dd
1 parent 04efda3
commit 499c4dd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/src/modules/weather-stations/weather-stations.controller.ts b/src/modules/weather-stations/weather-stations.controller.ts
@@ -50,7 +50,7 @@ export class WeatherStationsController {
 
   @Get(':id')
   findOne(@Param('id') id: string) {
-    return this.weatherStationsService.findOne(+id);
+    return this.weatherStationsService.findOne(id);
   }
 
   // TODO: refactor to weather-data module.
@@ -76,14 +76,7 @@ export class WeatherStationsController {
     }
 
     // Get points of the user of the weather station.
-    let pointsOfUser = null;
-    if (!weatherData) {
-      return {
-        weatherData,
-        pointsOfUser,
-      };
-    }
-    pointsOfUser = await this.pointsService.findByUserId(
+    const pointsOfUser = await this.pointsService.findByUserId(
       weatherData.author_user_id,
     );
 

diff --git a/src/modules/weather-stations/weather-stations.service.ts b/src/modules/weather-stations/weather-stations.service.ts
@@ -99,8 +99,8 @@ export class WeatherStationsService {
     return this.weatherStationModel.find();
   }
 
-  findOne(id: number) {
-    return `This action returns a #${id} weatherStation`;
+  findOne(id: string) {
+    return this.weatherStationModel.findOne({ _id: id });
   }
 
   async update(_id: string, updateWeatherStationDto: UpdateWeatherStationDto) {