Skip to content

Commit

Permalink
* Re-enabled ND tests
Browse files Browse the repository at this point in the history
* Reverted changes to README.md since there is another PR to update it.
  • Loading branch information
Cameron Crockatt authored and eli-guidewire committed Jul 22, 2020
1 parent b3ee8fd commit a38a9f4
Show file tree
Hide file tree
Showing 7 changed files with 33 additions and 24 deletions.
35 changes: 29 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,22 +45,45 @@ See [User Guide](https://gavinbunney.github.io/terraform-provider-bitbucketserve
- [Terraform](https://www.terraform.io/downloads.html) 0.12.x
- [Go](https://golang.org/doc/install) 1.11 (to build the provider plugin)

### Building The Provider

Clone repository to: `$GOPATH/src/github.com/gavinbunney/terraform-provider-bitbucketserver`

```sh
$ mkdir -p $GOPATH/src/github.com/terraform-providers; cd $GOPATH/src/github.com/terraform-providers
$ git clone [email protected]:gavinbunney/terraform-provider-bitbucketserver
```

Enter the provider directory and build the provider

```sh
$ cd $GOPATH/src/github.com/gavinbunney/terraform-provider-bitbucketserver
$ make build
```

### Developing the Provider

If you wish to work on the provider, you'll first need [Go](http://www.golang.org) installed on your machine (version 1.11+ is *required*). You'll also need to correctly setup a [GOPATH](http://golang.org/doc/code.html#GOPATH), as well as adding `$GOPATH/bin` to your `$PATH`.

Then clone the repository [Terraform provider bitbucket](https://github.com/gavinbunney/terraform-provider-bitbucketserver)

To compile the provider, run `make build`. This will build the provider and put the provider binary in the `$GOPATH/bin` directory.

```sh
$ make bin
...
$ $GOPATH/bin/terraform-provider-bitbucketserver
...
```

In order to test the provider, you can simply run `make test`.

```sh
$ make test
```

In order to run the full suite of Acceptance tests, run `make testacc-bitbucket`. Alternatively, you can run the
`scripts/start-docker-compose.sh` to start the Bitbucket docker container, run `make testacc` and then call
`scripts/stop-docker-compose.sh` when done running tests.
In order to run the full suite of Acceptance tests, run `make testacc`.

*Note:* Acceptance tests create real resources, and often cost money to run.

*Note:* Acceptance tests create real resources, and often cost money to run if not running locally.
```sh
$ make testacc
```
1 change: 0 additions & 1 deletion bitbucket/data_plugin_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (
)

func TestAccBitbucketDataPlugin_notifyer(t *testing.T) {
t.Skip("Skipping testing in CI environment")
config := `
resource "bitbucketserver_plugin" "test" {
key = "nl.stefankohler.stash.stash-notification-plugin"
Expand Down
8 changes: 3 additions & 5 deletions bitbucket/resource_group.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,8 @@ package bitbucket

import (
"fmt"
"net/url"
"strings"

"github.com/hashicorp/terraform/helper/schema"
"net/url"
)

func resourceGroup() *schema.Resource {
Expand Down Expand Up @@ -39,9 +37,9 @@ func resourceGroupCreate(d *schema.ResourceData, m interface{}) error {
groupName := d.Get("name").(string)
importIfExists := d.Get("import_if_exists").(bool)
var newResource = true
_, err := client.Post(fmt.Sprintf("/rest/api/1.0/admin/groups?name=%s", url.QueryEscape(groupName)), nil)
response, err := client.Post(fmt.Sprintf("/rest/api/1.0/admin/groups?name=%s", url.QueryEscape(groupName)), nil)
if err != nil {
if importIfExists && strings.Contains(err.Error(), "API Error: 409") {
if importIfExists && response.StatusCode == 409 {
newResource = false
} else {
return err
Expand Down
1 change: 0 additions & 1 deletion bitbucket/resource_plugin_config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (
)

func TestAccBitbucketPluginConfig(t *testing.T) {
t.Skip("Skipping testing in CI environment")
config := `
resource "bitbucketserver_plugin" "test" {
key = "de.codecentric.atlassian.oidc.bitbucket-oidc-plugin"
Expand Down
1 change: 0 additions & 1 deletion bitbucket/resource_plugin_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (
)

func TestAccBitbucketPlugin_install(t *testing.T) {
t.Skip("Skipping testing in CI environment")
config := `
resource "bitbucketserver_plugin" "test" {
key = "com.plugin.commitgraph.commitgraph"
Expand Down
1 change: 1 addition & 0 deletions docusaurus/docs/resource_group.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ resource "bitbucketserver_group" "browncoats" {
## Argument Reference

* `name` - Required. Group to create.
* `import_if_exists` - Optional. Import groups that already exist in bitbucket into the terraform state file.

## Import

Expand Down
10 changes: 0 additions & 10 deletions version.env

This file was deleted.

0 comments on commit a38a9f4

Please sign in to comment.