Added parentAverage and mendelianSampling functions #213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often copy between projects some version of a function that calculates parent average and Mendelian sampling. I guess this should be more generally useful to other AlphaSimR users, so I have added now more general versions of these functions into the package.
I do wonder how to best call these functions:
parentAverage()
,pa()
, or something else?mendelianSampling()
,ms()
, or something else?Also, I would appreciate feedback about the arguments. Should we pass in
mothers
andfathers
as arguments orparents
?parents
is convenient for monoecious species (we pass in just one pop).mothers
andfathers
is convenient for dioecious species (we would not have to combine pops).I have created a separate branch to create a new PR, but I see now that I have based this branch on top of the changes proposed in #211 (
asCategorical
PR). Let's squash the above questions and I can reopen a "clean" PR that is not based onasCategorical
PR.