Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parentAverage and mendelianSampling functions #213

Draft
wants to merge 4 commits into
base: devel
Choose a base branch
from

Conversation

gregorgorjanc
Copy link
Contributor

I often copy between projects some version of a function that calculates parent average and Mendelian sampling. I guess this should be more generally useful to other AlphaSimR users, so I have added now more general versions of these functions into the package.

I do wonder how to best call these functions:

  • parentAverage(), pa(), or something else?
  • mendelianSampling(), ms(), or something else?

Also, I would appreciate feedback about the arguments. Should we pass in mothers and fathers as arguments or parents?

  • Using parents is convenient for monoecious species (we pass in just one pop).
  • Using mothers and fathers is convenient for dioecious species (we would not have to combine pops).

I have created a separate branch to create a new PR, but I see now that I have based this branch on top of the changes proposed in #211 (asCategorical PR). Let's squash the above questions and I can reopen a "clean" PR that is not based on asCategorical PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant