Refactor build.sh initial lines and include SHELL_ON_ERRORS #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <[email protected]>
7 tasks
azeey
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR mainly implement the option to use
SHELL_ON_ERRORSvariable to define a trap in thebuild.shscript that will allow a local run of it that permits the jump into a shell inside the container if something fails. Relevant lines are injenkins-scripts/docker/lib/_common_scripts.bash. This should help with #923 .To avoid code duplication all over the place the PR also refactor the creation of the initial lines in
build.shto be in a single function include shebang, SHELL_ON_ERRORS, set -ex and timing.Tested it in: