Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SKIP_DEPRECATED functionality to ign-common #300

Closed
wants to merge 2 commits into from
Closed

Add SKIP_DEPRECATED functionality to ign-common #300

wants to merge 2 commits into from

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Jan 25, 2022 •
edited
Loading

Implementation of gazebosim/gz-cmake#204

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jan 25, 2022
@mjcarroll mjcarroll mentioned this pull request Jan 25, 2022
Open
@codecov
Copy link

codecov bot commented Jan 25, 2022 •
edited
Loading

Codecov Report

Merging #300 (c401832) into main (831924d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   77.13%   77.13%           
=======================================
  Files          76       76           
  Lines       10540    10540           
=======================================
  Hits         8130     8130           
  Misses       2410     2410

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f50d514...c401832. Read the comment docs.

@mjcarroll mjcarroll self-assigned this Feb 1, 2022
j-rivero
j-rivero reviewed Feb 2, 2022
View reviewed changes
CMakeLists.txt
@@ -40,6 +40,15 @@ elseif(WIN32)
option(USE_EXTERNAL_TINYXML2 "Use a system-installed version of tinyxml2" OFF)
endif()

#--------------------------------------
# Option: Should we skip tests of deprecated functionality
option(SKIP_DEPRECATED_TESTS "Skip testing deprecated funcationality" OFF)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the description, I would have a question: is this skipping the build of the deprecated tests or is this skipping the run of the deprecated tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the description, I would have a question: is this skipping the build of the deprecated tests or is this skipping the run of the deprecated tests?

The idea is to skip both. This would primarily be for local development as building/running those tests isn't particularly valuable when you are iterating quickly.

@j-rivero
Copy link
Contributor

j-rivero commented Feb 2, 2022

Looks good to me the feature. Do you prefer going on here or move it to ign-cmake and close this one?

@mjcarroll
Copy link
Contributor Author

Do you prefer going on here or move it to ign-cmake and close this one?

I'm going to make an ign-cmake version, I think it makes more sense there.

@mjcarroll mjcarroll closed this Apr 13, 2022
@mjcarroll mjcarroll deleted the skip_deprecated branch August 1, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero left review comments

Assignees

@mjcarroll mjcarroll

Labels
🌱 garden Ignition Garden
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjcarroll @j-rivero @nkoenig