Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bullet-featherstone: Remove joint motor constraint on joint force cmd #713

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jan 25, 2025

🦟 Bug fix

Fixes gazebosim/gz-sim#2729

Summary

Currently the joint motor responsible for enforcing a joint vel cmd does not disengage when a force command is received. This PR fixes the issue by removing the joint motor constraint whenever a joint force cmd is received.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

I confirmed that the new test expectations fail without the fix, and the fix works

@iche033 iche033 merged commit 7597a2c into gz-physics8 Jan 27, 2025
11 checks passed
@iche033 iche033 deleted the bullet_joint_motor_force branch January 27, 2025 17:59
@iche033
Copy link
Contributor Author

iche033 commented Jan 27, 2025

@Mergifyio backport gz-physics7

Copy link

mergify bot commented Jan 27, 2025

backport gz-physics7

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 27, 2025
iche033 added a commit that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bullet Bullet engine 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Joint velocity controller does not disengage with bullet-featherstone
2 participants