-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support visualizing mesh collisions with convex decomposition #2352
Conversation
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
…ams, refactor visualizaiton capabilities to use optimizeMesh function Signed-off-by: Ian Chen <[email protected]>
refactored to use the |
Signed-off-by: Ian Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a minor comment.
src/Conversions.cc
Outdated
} | ||
} | ||
if (setConvexDecomp) | ||
meshShape.SetConvexDecomposition(convexDecomp); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Could you remove the if
and let just meshShape.SetConvexDecomposition(convexDecomp);
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep removed. c74e7c1
Signed-off-by: Ian Chen <[email protected]>
🎉 New feature
Replaces #2331
Related gz-physics PR: gazebosim/gz-physics#611
Summary
Extends VisualizationCapabilities gui plugin to support visualizing mesh collisions with convex decomposition.
if a mesh collision has the new attribute , the plugin will decompose the meshes on the GUI side before visualizing them.
Test it
Here's a Cordless Drill Simplified model on fuel and a cordless_drill.sdf world for testing. This model uses convex decomposition on the collision mesh.
Optional: to actually have the collisions decomposed on the physics side, you'll need these PRs. This is not required to see the collision visualizations.
Then launch gz-sim with
bullet-featherstone
plugin:Right click on the drill model and view collisions:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.