Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: 2 to 3 #118

Merged
merged 8 commits into from
Nov 10, 2023
Merged

port: 2 to 3 #118

merged 8 commits into from
Nov 10, 2023

Conversation

mjcarroll
Copy link
Contributor

➡️ Forward port

Port gz-utils2 to main

Branch comparison: main...gz-utils2

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

mjcarroll and others added 8 commits September 29, 2023 13:04
Signed-off-by: Michael Carroll <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
This adds functions for using collections with the environment.  It
allows for conveniently retreiving and setting the environment variables
via a map, rather than individually.

This also adds a clearenv and printenv for completeness.

Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll self-assigned this Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #118 (2622106) into main (7bc8a8c) will increase coverage by 1.67%.
The diff coverage is 92.10%.

❗ Current head 2622106 differs from pull request most recent head d91ae74. Consider uploading reports for the commit d91ae74 to get more accurate results

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   80.11%   81.79%   +1.67%     
==========================================
  Files           8        8              
  Lines         342      401      +59     
==========================================
+ Hits          274      328      +54     
- Misses         68       73       +5     
Files Coverage Δ
cli/include/gz/utils/cli/GzFormatter.hpp 88.88% <ø> (ø)
include/gz/utils/Subprocess.hh 97.33% <100.00%> (+0.55%) ⬆️
src/Environment.cc 89.70% <86.04%> (-5.75%) ⬇️

... and 1 file with indirect coverage changes

@mjcarroll mjcarroll merged commit fed9d6a into main Nov 10, 2023
14 checks passed
@mjcarroll mjcarroll deleted the port/2_to_3 branch November 10, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants