Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require cmake version 3.22.1 #132

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Require cmake version 3.22.1 #132

merged 2 commits into from
Jul 30, 2024

Conversation

scpeters
Copy link
Member

🎉 New feature

Part of gazebosim/gz-cmake#350.

Summary

This increases our minimum required cmake version to 3.22.1 since we are already requiring that in gz-cmake4.

Test it

Check that CI is successful.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters scpeters requested a review from azeey as a code owner July 29, 2024 21:53
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 29, 2024
@azeey azeey merged commit ed26790 into main Jul 30, 2024
9 checks passed
@azeey azeey deleted the scpeters/require_cmake_3_22_1 branch July 30, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants