Update default camera instrinsics skew to 0, which matches spec

Signed-off-by: Shameek Ganguly <[email protected]>
gazebosim · May 23, 2024 · 47de8ea · 47de8ea
1 parent c9779cb
commit 47de8ea
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Camera.cc b/src/Camera.cc
@@ -208,7 +208,7 @@ class sdf::Camera::Implementation
   public: double lensProjectionTy{0.0};
 
   /// \brief lens instrinsics s.
-  public: double lensIntrinsicsS{1.0};
+  public: double lensIntrinsicsS{0.0};
 
   /// \brief True if this camera has custom intrinsics values
   public: bool hasIntrinsics = false;

diff --git a/src/Camera_TEST.cc b/src/Camera_TEST.cc
@@ -214,7 +214,7 @@ TEST(DOMCamera, Construction)
   cam.SetLensProjectionTy(2);
   EXPECT_DOUBLE_EQ(2, cam.LensProjectionTy());
 
-  EXPECT_DOUBLE_EQ(1.0, cam.LensIntrinsicsSkew());
+  EXPECT_DOUBLE_EQ(0, cam.LensIntrinsicsSkew());
   cam.SetLensIntrinsicsSkew(2.3);
   EXPECT_DOUBLE_EQ(2.3, cam.LensIntrinsicsSkew());