Use FILE_READ instead of new enum (#1442)

Signed-off-by: Steve Peters <[email protected]>
gazebosim · Jun 26, 2024 · 98d5c5e · 98d5c5e
1 parent f123f8e
commit 98d5c5e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/include/sdf/Error.hh b/include/sdf/Error.hh
@@ -179,9 +179,6 @@ namespace sdf
 
     /// \brief Generic error during parsing.
     PARSING_ERROR,
-
-    /// \brief File not found error.
-    FILE_NOT_FOUND,
   };
 
   class SDFORMAT_VISIBLE Error

diff --git a/src/SDF.cc b/src/SDF.cc
@@ -190,7 +190,7 @@ std::string findFile(sdf::Errors &_errors, const std::string &_filename,
   {
     if (!_config.FindFileCallback())
     {
-      _errors.push_back({sdf::ErrorCode::FILE_NOT_FOUND,
+      _errors.push_back({sdf::ErrorCode::FILE_READ,
         "Tried to use callback in sdf::findFile(), but the callback "
         "is empty.  Did you call sdf::setFindCallback()?"});
       return std::string();
@@ -378,7 +378,7 @@ void SDF::Write(sdf::Errors &_errors, const std::string &_filename)
 
   if (!out)
   {
-    _errors.push_back({sdf::ErrorCode::FILE_NOT_FOUND,
+    _errors.push_back({sdf::ErrorCode::FILE_READ,
       "Unable to open file[" + _filename + "] for writing."});
     return;
   }
@@ -546,7 +546,7 @@ const std::string &SDF::EmbeddedSpec(
   }
   catch(const std::out_of_range &)
   {
-      _errors.push_back({sdf::ErrorCode::FILE_NOT_FOUND,
+      _errors.push_back({sdf::ErrorCode::FILE_READ,
           "Unable to find SDF filename[" + _filename + "] with " +
           "version " + SDF::Version()});
   }