Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added World::ActorByName: #1436

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Added World::ActorByName: #1436

merged 2 commits into from
Jun 14, 2024

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jun 14, 2024

🎉 New feature

Summary

World::ActorByName didn't exist. This PR adds it.

Test it

Tests have been updated.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@nkoenig nkoenig requested review from azeey and scpeters as code owners June 14, 2024 13:28
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 14, 2024
@iche033 iche033 merged commit 7831063 into sdf13 Jun 14, 2024
11 checks passed
@iche033 iche033 deleted the nkoenig/actor-by-name branch June 14, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants