fixed collection search queries to join tables correctly https://gith… #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the idea is good but you need to rearrange the queries because some sql blocks like LIST_FILTER include the where clause inside so as it is it's not correct SQL syntax. |
yes tests are failing i will fix that |
ahakanzn
force-pushed
the
661--collection-search-facet-error
branch
3 times, most recently
from
67b1aa4 to
e55b1d7
Compare
ahakanzn
force-pushed
the
661--collection-search-facet-error
branch
from
e55b1d7 to
3dcc527
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ub.com//issues/661