expose encoding with default utf-8 for reading xml files #1084
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1083
It seems that some Windows installations do not open XML files with utf-8 encoding even when 1) the file is encoded as utf-8, 2) the XML declaration states it is utf-8, and 3) the
sys.getfilesystemencoding()
is utf-8.This seems to be because the system's
locale.getpreferredencoding()
sometimes defaults to cp1252 instead. This PR exposes anencoding
parameter to thegraph_from_xml
andfeatures_from_xml
functions so a user can manually specify a certain encoding if they need to.