Sprint 03 #29
Merged
Sprint 03 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Douglas019BR
commented
Feb 8, 2025
Douglas019BR
commented
- improve bestseller methods on bookmarket
- create public methods on bookstore to enable tests
- improve and divide tests from bestsellers
- fix populateBook method to return rand parameter
- refact: UpdateRelatedBooks
- feat: Adição de enum para tipificar o cliente
- feat: Alteração no Customer para poder ser criado com tipificação
- refact: Alteração nos metodos equals e hashCOde de Customer
- feat: Alteração no bookstore e no bookmarket para criar clientes de tipos diferentes
- fix: correção de teste unitario
- fix: javadocs no setRelatedBooks
- fix: Javadoc no getTopFiveRelatedBooks
- fiz: nome de variável
- fiz: nome de variável
- Update src/main/java/servico/bookstore/Bookstore.java
- fix: javadocs
- fiz: nome de variavel
- fiz nome de variavel
- Update src/main/java/servico/bookstore/Bookstore.java
- Update src/main/java/servico/bookstore/Bookstore.java
- Update src/main/java/servico/bookstore/Bookstore.java
- Update src/main/java/servico/bookstore/Bookstore.java
- Update src/main/java/servico/bookstore/Bookstore.java
- Update src/main/java/servico/bookstore/Bookstore.java
- feat: finalização do item
- feat: Inserção de atributos no Cart
- feat: Adição de escopo de amarração em Bookstore
- hot-fix fix the comment sintaxeon bookstore
- fix reotrno dos metodos de carrinho
- feat: Implementaçoes de carrinho no bookmarket
- fix: correções gerais
- add unit test to bestseller method on bookstore
- Update src/main/java/servico/bookmarket/Bookmarket.java
- Correções do comentario [U8BBxGu3] Feat - Criar amarração entre Customer, Cart e Bookstore #25 (comment)
- Correções do comentario [U8BBxGu3] Feat - Criar amarração entre Customer, Cart e Bookstore #25 (comment)
- Correções do comentario [U8BBxGu3] Feat - Criar amarração entre Customer, Cart e Bookstore #25 (comment)
- docs: Javacoc no metodo createEmptyCart
- [Tqv7puSp] feat - criar metodo GetMinimumBookPrice
- [Tqtr1gN8] feat - criar metodo GetBookPriceAverage
- fix: Stock deve conter livros
- changing function name and fix documentation from getAvarageBookCost
- fix java version on pom.xml
- fix test shouldGetTheAverageCostFromABook
- change toList() to collect(Collectors.toList());
- fix javadoc
Co-authored-by: Douglas Sermarini <[email protected]>
Co-authored-by: Douglas Sermarini <[email protected]>
Co-authored-by: Douglas Sermarini <[email protected]>
Co-authored-by: Douglas Sermarini <[email protected]>
Co-authored-by: Douglas Sermarini <[email protected]>
Co-authored-by: Douglas Sermarini <[email protected]>
Co-authored-by: Douglas Sermarini <[email protected]>
Co-authored-by: Douglas Sermarini <[email protected]>
Co-authored-by: Douglas Sermarini <[email protected]>
Co-authored-by: Douglas Sermarini <[email protected]>
Co-authored-by: Douglas Sermarini <[email protected]>
Co-authored-by: Douglas Sermarini <[email protected]>
Co-authored-by: Douglas Sermarini <[email protected]>
Co-authored-by: Douglas Sermarini <[email protected]>
Co-authored-by: Douglas Sermarini <[email protected]>
JoseitoOliveira
approved these changes
Feb 8, 2025
vitorgomes
reviewed
Feb 8, 2025
| .sorted((e1, e2) -> e2.getValue().compareTo(e1.getValue())) // Ordena por vendas (descendente) | ||
| .limit(top) // Filtra os N primeiros | ||
| .limit(limit) // Filtra os N primeiros |
There was a problem hiding this comment.
Nada critico que vou comentar, mas aqui nao teria que mudar o comentário? Anteriormente filtrava os primeiros, agora mudou o que filtra parece
vitorgomes
reviewed
Feb 8, 2025
| @Override | ||
| public Object executeOnBookstore(Stream<Bookstore> bookstore) { | ||
| List<Stock> stocks = bookstore.map(bk -> bk.getStock(this.bookId)) | ||
| .filter(stock -> stock != null && stock.getQty() > 0) |
There was a problem hiding this comment.
Aqui é meu monitor que ficou zuado ou a identaçao ta assim mesmo? O .filter ta la no canto da tela
vitorgomes
reviewed
Feb 8, 2025
| public Object executeOnBookstore(Stream<Bookstore> bookstore) { | ||
| return getBookstoreById(bookstore).getCart(cartId); | ||
| } | ||
|
|
vitorgomes
reviewed
Feb 8, 2025
| @@ -35,7 +35,11 @@ public RefreshCustomerSessionAction(int id, long now) { | |||
| */ | |||
| @Override | |||
| public Object executeOnBookstore(Stream<Bookstore> bookstore) { | |||
| Bookstore.refreshCustomerSession(cId, now); | |||
| try { | |||
| Bookstore.refreshCustomerSession(cId, now); | |||
There was a problem hiding this comment.
Aqui acho que não é meu monitor porque é bem sucinto o bloco, mas apareceu zuado a identação pra mim
vitorgomes
reviewed
Feb 8, 2025
| public void testGetCart() { | ||
| Cart cart = instance.getCart(1).get(); | ||
|
|
||
| assertFalse(cart == null); | ||
|
|
There was a problem hiding this comment.
\n (não sei se é costume geral de programador, mas la no trabalho o pessoal comenta "\n" onde o cara esqueceu uma linha pulada)
vitorgomes
reviewed
Feb 8, 2025
| Date birthdate = null; | ||
| String data = ""; | ||
| long now = 0L; | ||
| String fname = "João"; |
There was a problem hiding this comment.
Isso não poderia estar no setup do teste? Porque meio que utiliza os mesmo dados lá embaixo
vitorgomes
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.