Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] update proto #13

Merged
merged 1 commit into from
Feb 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions proto/feedback.proto
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ message PronunciationFeedbackDTO {
int32 pronunciation_score = 4;
int32 volume_score = 5;
int32 speed_score = 6;
string overall_feedback = 7;
string positive_feedback = 7;
string negative_feedback = 8;
}

message GetPronunciationFeedbackRequest {
Expand All @@ -23,7 +24,9 @@ message GetPronunciationFeedbackResponse {

message CommunicationFeedbackDTO {
string scene_id = 1;
string overall_feedback = 2;
string positive_feedback = 2;
string negative_feedback = 3;
string enhanced_answer = 4;
}

message GetCommunicationFeedbackRequest {
Expand Down
6 changes: 3 additions & 3 deletions proto/internal.proto
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ message PronunciationFeedbackRequest {
message PronunciationFeedbackResponse {
string transcript = 1;
repeated int32 incorrect_indexes = 2;
double pronunciation_score = 3;
double decibel = 4;
double speech_rate = 5;
int32 pronunciation_score = 3;
int32 volume_score = 4;
int32 speed_score = 5;
string positive_feedback = 6;
string negative_feedback = 7;
}
Expand Down
Loading