Reworked disconnected-mode fix, rebased layout patches #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids error messages and periodic reconnect attempts while we lack a network link. Once we gain a network again, we will be called anyway, allowing to reestablish the link. Signed-off-by: Jan Kiszka <[email protected]>
Left over from 76f6ca0. Signed-off-by: Jan Kiszka <[email protected]>
Move the roster entry icon a little bit left to have it vertically aligned with the action bar icon. Signed-off-by: Jan Kiszka <[email protected]>
This avoids layout changes for entries that gain/lose a status text. It will also make the visualization of entries with vs. without avatars cleaner. Signed-off-by: Jan Kiszka <[email protected]>
|
Great job! Thank you very much, the code is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now also stop reconnecting if all networks are disabled individually. Reconnect seems to works without delays anymore.
Please review/merge.
Jan