Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sending messages to instance ids #111

Merged
merged 1 commit into from
Aug 20, 2016

Conversation

dankingston
Copy link

I thought this could be useful...

If I have a GCM instance id (instead of a registration id), I cannot currently send push notifications.

These changes allow specifying the to field in a request. Per the GCM API documentation, the to field can be a registration token, notification key, or topic (i.e. not just a topic).

I'm now using my fork in a live project, but it would be easier if it was on PyPI!

Feel free to edit / reject / accept...

@coveralls
Copy link

coveralls commented May 31, 2016

Coverage Status

Coverage decreased (-6.2%) to 89.859% when pulling 42e06c1 on dankingston:develop into d10c855 on geeknam:develop.

@alibitek alibitek merged commit 9be5b80 into geeknam:develop Aug 20, 2016
@alibitek
Copy link
Collaborator

@dankingston Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants