add mouse trail length config option #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure I like how the shorter than 50 trail does not contain all the colors. |
|
This most recent commit changes the default behavior to only do 1 cycle of all the colors regardless of the number of Curves and tries to give party mode a consistent behavior regardless of the size too. One thing to note is that in the old behavior the full spectrum of colors isn't being used and caps at about 85% and leaves out some pinks and reds. So with the change, there is red on both sides of the trail because of where it loops. I think it is possible to shift the colors more so it isn't as noticeable.
vs the existing one
|
|
I went ahead and made the functionality similar to the existing version. |
…ength # Conflicts: # src/main/java/com/rainbowrave/RainbowRaveMouseTrailOverlay.java
geheur
force-pushed
the
master
branch
3 times, most recently
from
5135f00 to
f9499d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to configure how long to make the mouse trail.