Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resourecs: Update make.def to make is.D.x for x86 image #58

Open
wants to merge 4 commits into
base: stable
Choose a base branch
from

Conversation

Harshil2107
Copy link
Contributor

@Harshil2107 Harshil2107 commented Oct 9, 2024

This PR updates the compiler flags in make.def to make is.D.x for the x86 image

- To build is.D.x each isa would require different compiler flags.
Updating the location of make.def as there would be one for each ISA.
powerjg
powerjg previously requested changes Oct 9, 2024
src/npb-24.04-imgs/x86-npb.pkr.hcl Outdated Show resolved Hide resolved
@erin-le erin-le self-requested a review October 10, 2024 21:17
erin-le
erin-le previously approved these changes Oct 10, 2024
Copy link
Contributor

@erin-le erin-le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a good understanding of the make.def files, but I ran is.a, is.c, and is.d using the built disk image. is.a and is.c run while is.d seg faults, but this is probably expected behavior since it uses more memory than the X86Board can accommodate.

@mbabaie
Copy link

mbabaie commented Oct 14, 2024

I created the X86 disk image from this repo from scratch. Tested it on my own infrastructure that actually has a memory size > 3 GiB allowing to test is.D and it worked!

@erin-le erin-le self-requested a review October 25, 2024 00:52
Copy link
Contributor

@erin-le erin-le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants