Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gnosis chain symbol #221

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Fix Gnosis chain symbol #221

merged 2 commits into from
Jun 26, 2024

Conversation

0xh3rman
Copy link
Collaborator

@0xh3rman 0xh3rman commented Jun 25, 2024 •
edited
Loading

Fixes gemwalletcom/gem-ios#77 It's xDai

@0xh3rman 0xh3rman requested a review from gemcoder21 June 25, 2024 02:21
gemcoder21
gemcoder21 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@gemcoder21 gemcoder21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change GNO chain asset image too?

@0xh3rman
Copy link
Collaborator Author

It's the chain logo, I think we should keep GNO logo like we do for arbitrum and op

@0xh3rman 0xh3rman merged commit ffff71b into main Jun 26, 2024
3 checks passed
@0xh3rman 0xh3rman deleted the gnosis-symbol branch June 26, 2024 02:01
@l0vvkey
Copy link

l0vvkey commented Jun 29, 2024 •
edited
Loading

Got some XDAI. The wallet still shows GNO as ticker.
https://gnosisscan.io/tx/0x038990d34d7b8d898b9200433a9caad5b6c53f68b8909ec80cf67b41981a53de
telegram-cloud-photo-size-5-6338840570746749498-y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemcoder21 gemcoder21 gemcoder21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gnosis chain symbol should be xDAI
3 participants
@0xh3rman @l0vvkey @gemcoder21