Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor SPARQL to be faster and just return models by taxon id #97

Merged
merged 14 commits into from
Jun 18, 2024
Merged

refactor SPARQL to be faster and just return models by taxon id #97

merged 14 commits into from
Jun 18, 2024

Conversation

sierra-moxon
Copy link
Member

@sierra-moxon sierra-moxon commented Jun 17, 2024 •
edited
Loading

edit: fixes #94

@sierra-moxon sierra-moxon requested a review from balhoff June 17, 2024 21:30
balhoff
balhoff approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@balhoff balhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sierra-moxon I think I understand the change... if so it's good. :-)

@sierra-moxon
Copy link
Member Author

Thanks @balhoff - I'm sorry the PR got so unwieldy - I was trying all sorts of things to get the GH actions to pass. I mostly wanted your feedback on the SPARQL changes. Thank you for sorting through these 29 file changes for the relevant bits to review. I appreciate it!

@balhoff
Copy link
Member

balhoff commented Jun 18, 2024

Thanks @balhoff - I'm sorry the PR got so unwieldy - I was trying all sorts of things to get the GH actions to pass. I mostly wanted your feedback on the SPARQL changes. Thank you for sorting through these 29 file changes for the relevant bits to review. I appreciate it!

That's what I figured! The SPARQL is pretty different now but I think I see that it should work.

@sierra-moxon sierra-moxon merged commit ee56256 into main Jun 18, 2024
1 check passed
sierra-moxon added a commit that referenced this pull request Aug 12, 2024
@sierra-moxon
Merge pull request #100 from geneontology/fix_ise
f9a749d 
add generic error handling, return specific ValueError for issue #99, fixes #93, fixes #97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balhoff balhoff balhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Internal Server Error" from /api/taxon/{taxon}/models
2 participants
@sierra-moxon @balhoff