Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating #660

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

updating #660

wants to merge 4 commits into from

Conversation

eshant742
Copy link

I modified the variadic argument handling in the identifier visitor so that if there are no extra arguments (as in your printf example), the code:

Checks whether any extra variadic arguments exist before copying them.
Only removes the trailing comma and space if the argument string is non-empty.
Replaces the variadic placeholder with an empty string when there are no extra arguments.
This prevents the extra comma from being added and resolves the compilation error.

@neworderofjamie
Copy link
Contributor

neworderofjamie commented Mar 5, 2025

Thank you for this but, can you please revert the whitespace + indentation changes? We use K&R style indentation

@neworderofjamie
Copy link
Contributor

And you latest commit seems to also have reformatted all the comments in that file. Can you please not use whatever automatic code formatting tool you are using.

@neworderofjamie
Copy link
Contributor

neworderofjamie commented Mar 6, 2025

Thank you for undoing some of the formatting changes but you are still changing all the indentation from K&R to Allman style and making whitespace changes to almost every line! When you look in the files changed, all that should show up is your new code added at line 290.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants