Add automatic build of docker image to github packages #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gaetanbrl
reviewed
Feb 8, 2024
|
Qu'est-ce que tu veux dire par "viser un tag ultérieurement" ? |
Si je créé un tag, est-ce que l'image pourra partir de ce tag ou ce sera toujours la même branche ? (juste pour info) |
|
Normalement oui c'est censé le faire ici https://github.com/geo2france/mapstore2-georchestra/pull/1/files#diff-7c5b1aec3fd401c4634f1d2e303fa0b61fef81dd181322616a7058e833328a50R119 |
|
Good pour merge du coup ? |
Oui pardon, je pensais que tu allais merge suite à mon retour. |
|
Ha oui c'est mon habitude de ne merge que lorsque soit la PR a été "validée" avec le système de review de github ou soit qu'on me dit un truc du style LGTM :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will automatically build in Docker all new changes done in https://github.com/geo2france/mapstore2-georchestra/tree/2023.02.xx-custom to GitHub packages registry where it will be accessible from the public.
Accessible URL for docker: ghcr.io/geo2france/mapstore2-georchestra:2023.02.xx-custom