-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate async test #664
Activate async test #664
Conversation
…esses/__init__.py where other test processes are to facilitate reuse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello
Thank for the fix :)
The while loop is too simple, It need to handle a time out to avoid infinite waiting, and it also need check for Failed status.
Otherwise pytest is working, when test do not fail :)
Best regards.
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me
Maybe you should capitalise commit messages :)
Best regards
@huard thanks :) |
Overview
A unit test for asynchronous processes was not actually running asynchronously. The test now runs in async mode and will raise an error if it ever runs synchronously.
Related Issue / Discussion
In response to comments in #657
Additional Information
Depends on #663
Contribution Agreement
(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)