-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cli improvements #198
Cli improvements #198
Conversation
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber-stamping this, I can't really review it properly.
Co-authored-by: Laurențiu Nicola <[email protected]>
Hum, I don't have this one on my side. |
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Yeah indeed, I spotted that one and removed it. |
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Convert existing (RINEX-cli) opmodes into
clap::Subcommands
.The application has several opmodes that are exclusive.
Subcommands which are exclusive by nature, are the ideal way to depict them.
Subcommands then has several benefits
I merged the
RNX2CGGTTS
binary into a RINEX-cli -p -cggtts opmode.Indeed, this one uses the -p behavior, with a customized output. The previous implementation had the code duplicated.
It also required to update both applications on any dependency upgrade.
I renamed the previous "default opmode" to "--graph -G". Considering it's more data visualization oriented.
I'm also introducing a script to test the major applications. Since we're shipping those applications online now, it is almost mandatory to have more CLI/applications continuous integration.
Details
We only have a couple of commands that are shared accross opmodes:
The current opmodes are (use -h for each of them):
It's basically the previous ""default"" opmode, that would generate
Record visualization.
(1) is the general front panel: basically everything that is shared with other opmodes
(2) are the opmodes: you have to select one (and can only select one) to actually do something
Example of subcommand help/documentation :
(3): RNX2CGGTTS is now a precise positioning opmode. It makes maintaining this operation easier.
It reduces the code quantity: can share the solver logic. It allows sharing the Solver configuration file -c...