-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEOS-11702] GeoFence: major libs update #8254
base: main
Are you sure you want to change the base?
Conversation
There's a single error when compiling with JDK21:
Byte Buddy is used by hibernate instead of javaassist since version 5.3CR2 (where long ago javassist replaced cglib) |
|
||
#. Extract the files in this archive to the :file:`WEB-INF/lib` directory of your GeoServer installation. | ||
|
||
.. warning:: this plugin will install a version of the `H2 <http://www.h2database.com>`__ library that **is not compatible** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would indicate that it's also safe to remove (it is, right?), in other words, that it's possible to use GeoFence with NetCDF/Grib provided the H2 v2 database is removed and the rule storage is moved to an external database.
I see it's written down in the same page, but some careless user might not read to the end, better to inform them now and indicate there are instructions later in the page.
@@ -1073,6 +1073,14 @@ | |||
<artifactId>gs-geofence-server</artifactId> | |||
<version>${project.version}</version> | |||
</dependency> | |||
<!-- Older versions of h2 fail in drop/create tables --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it needed? The dependency towards gs-geofence-server should be enough, it's already declared as a dependency there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without it, mvn will usee the 1.1 version :|
|
||
<!-- Older versions of h2 fails in drop/create tables --> | ||
<!-- This version may break netcdf/grib modules --> | ||
<!-- Please do consider using a postgis backend instead --> | ||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we shoud have a profile to enable/disable this dependency.
Use case, starting GeoServer during development with both geofence and netcdf, with this setup it would be impossible...
Looks like we have a legit failure under Java 21:
while not yet officially supported, we're keeping the entire GeoServer working under Java 21 too. Saw your comment about it only now. At a minimum, disable the test under Java 21, the builds must be all green. |
Update many libs according to GeoFence 3.8
Major points:
GeoFence 3.8 SNAPSHOT is not merged into geofence/main yet, but has been already built and deployed in the osgeo maven repo.
Checklist
main
branch (backports managed later; ignore for branch specific issues).For core and extension modules:
[GEOS-XYZWV] Title of the Jira ticket
.