Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10893 Making sure scripts from extensions are not cached #10895

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Feb 28, 2025

Description

This way intex.js is appended by a random param making sure that script will not be cached.
I just noticed that removeExtensions seems not be triggered when removing the installed extension. can you double check is the case?

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

Fix #10893

What is the new behavior?

index.js of the extensions will not be cached

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

to test this locally when targeting dev env

 '/extensions/': {
            target: MAPSTORE_BACKEND_URL,
            secure: false,
            headers: {
                host: domain
            }
        },
        '/configs/pluginsConfig.json': {
            target: MAPSTORE_BACKEND_URL,
            secure: false,
            headers: {
                host: domain
            }
        }

@MV88 MV88 added this to the 2025.01.00 milestone Feb 28, 2025
@MV88 MV88 requested a review from dsuren1 February 28, 2025 14:54
@MV88 MV88 self-assigned this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure extensions files are not cached
1 participant