fix: Fallback to format=1 if not format for sample index #420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the intent this code in
getReaderForSample
is to always ensureformat
is defined. However, I ran into an edge case when loading an OME-TIFF where for some reasonSampleFormat
is defined but the format for specific sample index is missing, causingformat: undefined
, and throwing:A snapshot of this edge case from the debugger:
You can see
format: undefined
. This PR keeps the current behavior but falls back to format: 1 in the additional case whereSampleFormat
is defined but there is no entry for thesampleIndex
.Apologies for the screenshots. The changes are very minimal, I just want to make sure this is the intended behavior. It seems the intent of the code is to always have
format
defined, but this is an edge case where it is not.