Restore and test masking implementation #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jisantuc
changed the title
|
Great catch, I'm glad this was an easy fix. I'd say that testing in general could use some love but that the change here is pretty minimal - you could (assuming your schedule permits) manually create an AST that uses masking/some super simple |
|
The RDD work which is killing travis can be ignored; I've created an issue at #73 |
|
I think that's what I did in eb5722c |
|
It's tough to tell though because I can't compile tests 😞 |
jisantuc
force-pushed
the
feature/js/use-non-deprecated-cross-project
branch
from
c314c56
to
2e64591
Compare
1 task
This reverts commit d5c1f1e.
jisantuc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR restores the implementation of
Masking -> MaskingNodeand upgradessbt-crossprojectnotto use a deprecated version.
I'm not really sure how to test things.