Skip to content
This repository has been archived by the owner on Apr 7, 2019. It is now read-only.

Commit

Permalink
V1.0.9.17 2017 Nov 13
Browse files Browse the repository at this point in the history 
- Fix to allow entry of '-' in Work Position text boxes, Issue #111
  • Loading branch information
gerritv committed Nov 13, 2017
1 parent a2f66b7 commit 80366b2
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 3 deletions.
2 changes: 2 additions & 0 deletions CHANGES.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
This file documents changes made:
V1.0.9.17 - 2017 Nov 13
- Fix to allow entry of '-' in Work position text boxes, Issue #111
V1.0.9.16 - 2017 Nov 10
- Fix crash on invalid tool number< Issue #128
- Implement configurable rounding, Issue #116
Expand Down
2 changes: 2 additions & 0 deletions Grbl-Panel/CHANGES.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
This file documents changes made:
V1.0.9.17 - 2017 Nov 13
- Fix to allow entry of '-' in Work position text boxes, Issue #111
V1.0.9.16 - 2017 Nov 10
- Fix crash on invalid tool number< Issue #128
- Implement configurable rounding, Issue #116
Expand Down
5 changes: 4 additions & 1 deletion Grbl-Panel/GrblGui.vb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,10 @@ Public Class GrblGui
Not _gui.gbEditor.ContainsFocus And
Not _gui.gbSettingsMisc.ContainsFocus And
Not _gui.gbSettingsJogging.ContainsFocus And
Not _gui.gbSettingsPosition.ContainsFocus Then ' in case user is working in MDI
Not _gui.gbSettingsPosition.ContainsFocus And
Not _gui.tbWorkX.ContainsFocus And
Not _gui.tbWorkY.ContainsFocus And
Not _gui.tbWorkZ.ContainsFocus Then ' in case user is working in MDI
Select Case msg.WParam
' Act on Distance Increment keyboard requests
Case Keys.Add, Keys.Oemplus And My.Computer.Keyboard.ShiftKeyDown
Expand Down
4 changes: 2 additions & 2 deletions Grbl-Panel/My Project/AssemblyInfo.vb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Imports System.Runtime.InteropServices
' by using the '*' as shown below:
' <Assembly: AssemblyVersion("1.0.*")>

<Assembly: AssemblyVersion("1.0.9.16")>
<Assembly: AssemblyFileVersion("1.0.9.16")>
<Assembly: AssemblyVersion("1.0.9.17")>
<Assembly: AssemblyFileVersion("1.0.9.17")>

<Assembly: NeutralResourcesLanguageAttribute("en-CA")>

26 comments on commit 80366b2

@KM6VV
Copy link

@KM6VV KM6VV commented on 80366b2 Apr 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does GrblPanel expect for an IP connection? Is it similar to LaserGRBL? Is there a link to more info?

Thanks, Al

[email protected]

@1Metalguru
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GRBL Panel doesn't use IP. It uses USB. The GRBL motion controller is an Arduino with USB/Serial converter on board.

https://github.com/gerritv/Grbl-Panel/wiki

@Sunnysky
Copy link

@Sunnysky Sunnysky commented on 80366b2 Apr 19, 2018 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KM6VV
Copy link

@KM6VV KM6VV commented on 80366b2 Apr 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have recently found Grbl Panel, and I love it! It reminds me of the old DOS controller I wrote 16+ years ago (and still use).

I have 1.0.9.16 and GRBL 1.1f. On the interface panel Grbl box next to 'COM', I see 'IP'. I don't know much at all about the WebSocketsServer that LaserGrbl uses in the ESP8266 WiFi connection, but I thought it might be similar. Maybe future feature?

I write in 'C'; and don't know enough about WebSockets, so I doubt if I could add it.

I really appreciate the single step '-' control, I have one in my software. Another feature I'd like to see is a 'goto' function. I have one, and use it all the time. I like to be able to start code at several different points in the Gcode file. Of course, files would need to have line numbers (which I like anyway).

I'll look for TeamViewer.

Thanks.

@1Metalguru
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah not sure what the IP stuff on GRBLPanel is for. Obviously, it's not to connect to an arduino. It doesn't make any sense, really, since GP is only made to connect to an Arduino running GRBL, which doesn't support IP in any way, shape, or form. Nor does it make any sense to connect to anything behind GP with an IP connection, what would it be used for? Perhaps a question for Gerrit...

@hilam8899
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I am using stm32f407 and Raspberry Pi to make the HOST, slave is stm32f103, the HOST is connecting to SLAVE using ESP8266 .I plan to build my cloud platform。

@KM6VV
Copy link

@KM6VV KM6VV commented on 80366b2 Apr 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I've not used STM parts.

@joebananas10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IP connectivity was added back in V1.0.3.0, Nov 2014. It was issue #13; you can review the original dialog between @gerritv and @tylerv there #13

@KM6VV
Copy link

@KM6VV KM6VV commented on 80366b2 Apr 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed #13, looks like @tylerv added added IP code, but I wasn't able to determine what. Links are dead. WiFly is expired product. Shapeono dead end as well. Sure like to try out a Wifi connection via an ESP8266...

@joebananas10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WiFly is an Arduino shield, i.e. an addon card for the Arduino board. The link to the old Shapeoko blog is dead but you can still find the old discussions about it at the Shapeoko forums, https://www.shapeoko.com/forum. If you search for Shapeoko references on the blog at inventables.com , http://blog.inventables.com/, you might be able to find the old article. That time frame was just about when Shapeoko and Inventables went their separate ways. You can get information about the WiFly shield at SparkFun, https://www.sparkfun.com/. There's probably other places that offer them but I'm not sure.
Good Luck.

@KM6VV
Copy link

@KM6VV KM6VV commented on 80366b2 Apr 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll take a look.

@1Metalguru
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm posting this here because I can't figure out how to put up a bug report on the main page.

This is a relatively minor bug, but the Unlock button and the Status box do not turn red on connect or on reset if the Homing is not enabled (no homing button). If the Homing is enabled in the GRBL settings window, all 3 buttons turn red on startup, connect, or reset.

It appears that the Unlock button still works, you just cant tell if anything happens when you push it.

V 1.0.9.17

Metalguru

@gerritv
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1Metalguru I will take a look in the next week, should be a simple fix.

I disabled Issues because I was stepping back from this project for a while. After the summer I will get things moving ahead again.

@1Metalguru
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gerrit. Have a good vacation!

MG

@terjeio
Copy link

@terjeio terjeio commented on 80366b2 Jul 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enhanchment request for code in GrblUtils.vb:

The constants in the following code segment should preferably be replaced with values from the [OPT: report?

Case "Bf"
                            
    Dim values = Split(portion(1), ",")
    Try
        prgBarQ.Value = 15 - values(0)
        prgbRxBuf.Value = 128 - values(1)
    Catch
End Try

Terje

@1Metalguru
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Gerrit:

You mentioned a couple of months ago that you would take a look at the Reset issue mentioned above. Any progress on that?

Also, I have recently started using an Xbox controller with key mapping software to operate my machine. Works really well, but I've run into a few issues:

I rely heavily on Disconnect/Reconnect button to zero out the machine. It's so much simpler than using G54-59. It would be really nice if this button had a key mapped to it, as it is I cannot set it up on my controller because it has no key map.

Also, ditto for the Home, Special Position 1 and 2 buttons. I use those a lot, it would be really nice if they had keys mapped as well.

Thanks Gerrit

@gerritv
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am finally looking at the last few reported issues. Perhaps I should re-enable Issues again as it might work a bit better for everyone. I think I am ready to do some CNC design work for my own machine.

@1Metalguru re: key mappings, can you make some suggestion on key combos for the extra ones?

@1Metalguru
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Gerrit

Well, I don't know if there are any "reserved" key mappings, or cross pollination with some Windows key combinations, but here goes:

Home - Ctrl-H, or perhaps the obvious choice, the Home key
SP1, SP2 - perhaps Ins and Del, or < and >
Connect - How about Ctrl-C, or Tab? This would be a toggle, connect/disconnect
Start - maybe S, or Ctrl-S The space bar toggle only does hold/resume, it doesn't do a Start (or Play) of the loaded g-code.

While we are at it, someone mentioned in another thread about the issue with the right, left, up, and down arrows, and page up and page down for movement. These keys have a high repeat rate, and fill the receive buffer very fast. If you hold them down just a bit too long, it's easy to crash the machine into the endstops. The on screen arrow keys don't do this, or at least have a much slower accumulation rate in the receive buffer. If possible, it would be great if both of these sets of keys stopped immediately as soon as they were released. Not sure if this is possible, since the commands are already in the receive buffer, but take a look.

Also, having the Tool Change implemented would be great, just pause the program so a manual tool change could be done, allow the Z axis to be rezeroed with the new tool, and then continue execution.

Anyway, enough already. Thanks Gerrit.

@terjeio
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KM6VV IP-support may become relevant again. bdring has ported grbl to ESP_32 and I am working on a HAL driver for TI's TM4C1294 LanchPad which I want to add ethernet support for. Ethernet (like WiFi) is potentially better than USB or serial in noisy environments as it is an electrically floating interface.

I am running Mach3 with a SmootStepper interface for my primary router and is a bit spoiled by that, having keyboard jogging and camera support. The camera is a must for aligning workpieces (like PCBs for drilling), and made quite easy since Mach3 has keyboard jogging with rollover support that can be modified with SHIFT (fast) and CONTROL (step) keys. It is a pity that jog cancel in grbl is not reliable and thus makes it impossible(?) to implement jogging similar to Mach3. However, I believe I have managed to fix that and have made a function (in C#) that overrides ProcessKeyPreview that so far has worked without a hitch for me. I can post this if of interest.

As for the camera I have a test program working (based on AForge libs) that I plan to integrate in my sender, this as a control. If correctly made I believe this could be added to Grbl-panel, or other .NET based senders, in a tab without too much work. Again, if of interest, I can publish this as a project (the control, not the sender - which I do not intend to publish).

camera

@gerritv
Copy link
Owner

@gerritv gerritv commented on 80366b2 Sep 3, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1Metalguru Re: This is a relatively minor bug, but the Unlock button and the Status box do not turn red on connect or on reset if the Homing is not enabled (no homing button). If the Homing is enabled in the GRBL settings window, all 3 buttons turn red on startup, connect, or reset.

The symptom exists because when Homing =0, Grbl does not send [MSG:'$H'|''$X' to unlock] message when connecting. The status response to ? is <Idle...., not <Alarm as it would be initially when Hoing is enabled. So unfortunately there is nothing else from Grbl to tell me there is a situation that requires Unlock or Alarm. Performing an Unlock at that point does nothing functional.

@gerritv
Copy link
Owner

@gerritv gerritv commented on 80366b2 Sep 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terjeio Re: Enhanchment request for code in GrblUtils.vb:
The constants in the following code segment should preferably be replaced with values from the [OPT: report?

Case "Bf"
                            
    Dim values = Split(portion(1), ",")
    Try
        prgBarQ.Value = 15 - values(0)
        prgbRxBuf.Value = 128 - values(1)
    Catch
End Try

This is now implemented, will release soon.

@gerritv
Copy link
Owner

@gerritv gerritv commented on 80366b2 Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terjeio I would be interested in using the Camera control in GrblPanel. What is best way for me to get the code?

@terjeio
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gerritv I have published the code over at my GitHub page, enough to get you started? Later I intend to publish binaries as well.

@gerritv
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I am ramping up my C# and XAML skills for Version 2.0 :-)

@terjeio
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gerritv It seems that the IP-support is possibly broken. I just managed to make Grbl to run as a FreeRTOS task together with lwIP and although Grbl-Panel seem to transmit data correctly, parsing the real-time response fails - e.g. such as displaying wrong data in the DRO. Also, my test job that normally runs in about 15 minutes took more than 25 minutes to complete.

Adding (quick-and-dirty?) IP-support to my controls library and running the same test in one of my senders did not show the same behaviour, and the job took about 30 seconds more to complete.

I can look into this for you when I am back at my Win10 machine as this has a more recent VS version than the laptop that I am currently using. Or are you going to drop IP-support?

@gerritv
Copy link
Owner

@gerritv gerritv commented on 80366b2 Oct 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terjeio @1Metalguru Release 1.0.9.18 is ready for your enjoyment.

Please sign in to comment.