Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: payment component #106

Merged
merged 24 commits into from
Nov 22, 2023
Merged

Feat: payment component #106

merged 24 commits into from
Nov 22, 2023

Conversation

rolznz
Copy link
Collaborator

@rolznz rolznz commented Nov 11, 2023

Fixes #62

Testable at https://bitcoin-connect-request-payment-modal--rolznz.repl.co/ (desktop and mobile - unfortunately on mobile replit keeps refreshing the page so Alby NWC does not work)

image

image

  • Add payment page
  • programmatically pass the invoice to launchModal (address Move launchModal to root package #63)
  • Extract amount from invoice to display using lightning tools
  • Fix: GetBalance is called even though your balance isn't shown in the request payment screen
  • Fix header not showing on payment request screen
  • Copy invoice to clipboard - Icon and animation
  • Open invoice in wallet button
  • Use a proper QR library rather than QR API
  • Handle QR code in dark mode (for now it looks ugly but it works)
  • Add support in React wrapper
  • Automatically closing the modal after the success animation
  • Mobile styles
  • embed the success gif in bitcoin connect (not host it externally)

@rolznz rolznz marked this pull request as ready for review November 20, 2023 16:38
@rolznz rolznz requested a review from reneaaron November 20, 2023 16:38
@rolznz rolznz changed the title Feat/payment component Feat: payment component Nov 20, 2023
@rolznz rolznz mentioned this pull request Nov 22, 2023
Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@rolznz rolznz merged commit ff2d1d8 into master Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add component to simplify making payments
2 participants