fix: show auth prompt only once #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im-adithya
reviewed
Nov 4, 2024
| const handleUnlock = useCallback(async () => { | ||
| // The call `signIn()` below triggers a re-render of the component | ||
| // and would prompt the user again (before the actual redirect | ||
| // happens and the view is replaced) |
There was a problem hiding this comment.
Ah I was wondering why this happens, I thought it only happens during dev, thanks for the fix 🙌
There was a problem hiding this comment.
What made you think it only happens during dev? Please properly test these things, I guess this was introduced during the eslint update.
There was a problem hiding this comment.
It didn't happen when I installed it from the AppStore, I tried to reproduce several times. But it happened during dev.
And I'm not sure if this is after the eslint update as I used to see it even before that...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #178