fix: use compare package to compare versions

getAlby · Oct 8, 2024 · 4c7486b · 4c7486b
1 parent 71183a1
commit 4c7486b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/frontend/package.json b/frontend/package.json
@@ -44,6 +44,7 @@
     "canvas-confetti": "^1.9.2",
     "class-variance-authority": "^0.7.0",
     "clsx": "^2.1.0",
+    "compare-versions": "^6.1.1",
     "date-fns": "^3.6.0",
     "dayjs": "^1.11.10",
     "embla-carousel-react": "^8.0.2",

diff --git a/frontend/src/components/layouts/AppLayout.tsx b/frontend/src/components/layouts/AppLayout.tsx
@@ -1,3 +1,4 @@
+import { compare } from "compare-versions";
 import {
   Cable,
   Cloud,
@@ -327,7 +328,7 @@ function AppVersion() {
   const upToDate =
     info.version &&
     info.version.startsWith("v") &&
-    info.version.substring(1) >= albyInfo.hub.latestVersion;
+    compare(info.version.substring(1), albyInfo.hub.latestVersion, ">=");
 
   return (
     <TooltipProvider>

diff --git a/frontend/yarn.lock b/frontend/yarn.lock
@@ -3095,6 +3095,11 @@ compare-func@^2.0.0:
     array-ify "^1.0.0"
     dot-prop "^5.1.0"
 
+compare-versions@^6.1.1:
+  version "6.1.1"
+  resolved "https://registry.yarnpkg.com/compare-versions/-/compare-versions-6.1.1.tgz#7af3cc1099ba37d244b3145a9af5201b629148a9"
+  integrity sha512-4hm4VPpIecmlg59CHXnRDnqGplJFrbLG4aFEl5vl6cK1u76ws3LLvX7ikFnTDl5vo39sjWD6AaDPYodJp/NNHg==
+
 [email protected]:
   version "0.0.1"
   resolved "https://registry.npmjs.org/concat-map/-/concat-map-0.0.1.tgz"