Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show hub interactions on app store detail pages #1022

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Jan 21, 2025

Closes #1008

image

Copy needs review.

Also commented out nostr.kiwi for now, seems broken.

@MoritzKa
Copy link
Contributor

Is it about the interactions between Alby Hub and the app or is it about a short description what you can do in this app?

I'd vote for the latter and rename the title from "Alby Hub Interaction" to "About this App"

I added minor changes. Most apps are similar so I would just copy the description over.
What's easier to handle for you? An own PR or comments as above?

@rolznz
Copy link
Contributor Author

rolznz commented Jan 21, 2025

@MoritzKa you could edit this branch directly, or give me comments and I can address them

MoritzKa and others added 4 commits January 21, 2025 14:06
I'd emphasize on what you can do with the app together with Alby Hub.
The technical interaction details are maybe less important at this point when it is about discovery of an app.
@rolznz rolznz merged commit 6d78989 into master Jan 22, 2025
9 of 10 checks passed
@rolznz rolznz deleted the feat/app-store-interactions branch January 22, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain how wallet is used in app store apps
2 participants