Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default redirect on settings route #232

Merged
merged 2 commits into from
Jul 9, 2024
Merged

fix: default redirect on settings route #232

merged 2 commits into from
Jul 9, 2024

Conversation

pavanjoshi914
Copy link
Contributor

@pavanjoshi914 pavanjoshi914 commented Jul 9, 2024 •
edited
Loading

properly tested

@rolznz
Copy link
Contributor

rolznz commented Jul 9, 2024

@pavanjoshi914 can you fix the issue rather than just closing it?

@rolznz rolznz reopened this Jul 9, 2024
@pavanjoshi914 pavanjoshi914 requested a review from rolznz July 9, 2024 09:58
reneaaron
reneaaron approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@reneaaron reneaaron merged commit f728190 into master Jul 9, 2024
8 checks passed
@reneaaron reneaaron deleted the settings-default-redirect branch July 9, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneaaron reneaaron reneaaron approved these changes

@rolznz rolznz Awaiting requested review from rolznz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavanjoshi914 @rolznz @reneaaron