feat: update gonuts dependency #962

elnosh · 2025-01-08T19:36:26Z

This is a WIP for #890 so marking as draft.

I have made changes for new gonuts version, however not pointing to v0.3.0 but instead to latest commit in main for now since I have changed some things since v0.3.0.

This should handle pending proofs that are stuck in payments and hence not try to use them in other payments.

Another change for this new version is that it does not have an Invoice type anymore and instead MintQuote and MeltQuotes so it has to aggregate those 2 when listing transactions.

Regarding point 4 in #890, I think doing a restore if it finds any pending proofs during startup could be undesirable since the restore does not restore previous transaction history. So any time there are pending proofs and the hub starts, it will wipe out the transaction history. Maybe a cashu-backend specific button could be added in Settings > debug tools where if the user experienced the issue of a unusable wallet due to stuck payments, they could trigger a manual restore?

Regarding this issue #651, I know it's not ideal not having the preimage for incoming payments and one is expected but maybe a dummy/placeholder one could be used so that the hub can mark it as settled and show up in the transaction history and don't go into that loop where it would always check that invoice even though it already got paid.

Any thoughts or comments on the changes and suggestions made here are appreciated :)

rolznz · 2025-01-09T04:24:37Z

Thanks for picking this up @elnosh !

Regarding point 4 in #890, I think doing a restore if it finds any pending proofs during startup could be undesirable since the restore does not restore previous transaction history. So any time there are pending proofs and the hub starts, it will wipe out the transaction history. Maybe a cashu-backend specific button could be added in Settings > debug tools where if the user experienced the issue of a unusable wallet due to stuck payments, they could trigger a manual restore?

That sounds better, but I would prefer to not leak individual LNClient-specific code to other parts of the app. It might be best to have a generic "Execute Node Command" button in the debug tools where you can type some text, and then the Cashu implementation can parse it and do what it needs. We originally planned to do something like this but did not yet add it. I will see what we can do and get back to you. CC @rdmitr

Regarding this issue #651, I know it's not ideal not having the preimage for incoming payments and one is expected but maybe a dummy/placeholder one could be used so that the hub can mark it as settled and show up in the transaction history and don't go into that loop where it would always check that invoice even though it already got paid.

This sounds like a good workaround to me!

rolznz · 2025-01-09T04:26:53Z

lnclient/cashu/cashu.go

 	}
-
-	fee := uint64(transaction.FeesPaid)
+	totalPaid := balanceBeforeMelt - cs.wallet.GetBalance()


minor: could this generate an incorrect fee if there were two simultaneous payments? (but I don't think we need to change anything here)

yeah thanks for catching that, if another transaction happens in between it could generate incorrect fee. A better way could be to use the Change from the melt response and then do FeeReserve - ChangeAmount.

rolznz · 2025-01-09T05:19:28Z

@elnosh for now temporarily we could put the reset logic in this function just to test it, and not block this PR:

func (cs *CashuService) ResetRouter(key string) error {
	return nil
}

It's not so good because it's unrelated to resetting the wallet, but it is executed from the dev tools page.

elnosh · 2025-01-10T19:54:52Z

made some other changes:

saving mnemonic from cashu wallet
test cashu wallet restore from the ResetRouter in the debug tools
added dummy preimage for mint quotes so that those get marked as settled.

rolznz · 2025-01-15T08:56:59Z

Adding for reference, if a user gets a message no mint URL was set, we removed it in a previous PR as we incorrectly set an unstable cashu test mint as the default #535

rolznz · 2025-01-15T09:12:46Z

I found an old cashu wallet for Alby Hub with mint https://8333.space:3338 which is operational (I can pay with my old balance) and I can send payments, but when I pay I get "no preimage in melt response". My balance then does not update after paying. Is this expected?

Update: I paid some more and now my balance says 33 sats - but it is not, I can no longer pay.

I managed to restore the proofs at https://wallet.cashu.me/ - nice! afterwards, I could still pay with my hub (I thought the tokens would have become invalid).

rolznz · 2025-01-15T10:04:11Z

Starting a brand new hub with a new cashu wallet seems to work well.

Restoring my sats on the old wallet with the incorrect balance changed it from 33 to 11 sats.

With minibits I get the balance issue.
I deposited 10 sats, then paid 1 sat. Now my balance is 12. Maybe just a calculation bug?

rolznz · 2025-01-15T10:05:55Z

lnclient/cashu/cashu.go

-			}
+	cashuWalletMnemonic := cashuWallet.Mnemonic()
+	mnemonic, _ := cfg.Get("Mnemonic", encryptionKey)
+	if mnemonic != cashuWalletMnemonic {


this will overwrite an existing mnemonic (there shouldn't be one). But should the check be if mnemonic == "" ?

Actually, if the mnemonic is different and not an empty string, we should probably return an error rather than overwriting it.

I was first checking if it was empty but while testing it seems a different (from cashu wallet's) mnemonic was being created and set so that's why I put that check. I'm assuming the different one was set in first startup.

So what does this mean for existing hub users? their old mnemonic will be overwritten, right?

looking at this: https://github.com/getAlby/hub/blob/master/service/keys/keys.go#L63-L75 it seems one is created anyways even if the mnemonic is set to false for any specific backend. So mnemonic would never be empty. Maybe this mnemonic should not be overwritten (?). I'm not sure what it's used for. Should I put the cashu wallet mnemonic in some other key?

Damn, I see. Ideally we use the one that Alby Hub generates as that's the one we ask the user to back up as part of the getting started steps, and then we pass that mnemonic to gonuts. Is this possible?

If gonuts always overwrites the mnemonic it is inconsistent with the rest of our LNClients and will cause other issues later on.

If gonuts always overwrites the mnemonic it is inconsistent with the rest of our LNClients and will cause other issues later on.

Ok, instead of doing it this way maybe it can just be another command with that "Node Command" API you guys are planning? Send command to cashu wallet and that would return the mnemonic.

That way it wouldn't need to overwrite the mnemonic created in first setup.

@elnosh I guess that's acceptable. Then we also need to undo the change to display that the cashu connector. I will add a comment. Thanks!

The commands PR is in progress and should be hopefully ready early next week: #1007

To move cashuWallet.Mnemonic() to a node command

rolznz · 2025-01-15T10:07:18Z

frontend/src/screens/settings/DebugTools.tsx

@@ -304,7 +304,7 @@ export default function DebugTools() {
              Get Network Graph
            </Button>
          </AlertDialogTrigger>
-          {info?.backendType === "LDK" && (
+          {(info?.backendType === "LDK" || info?.backendType === "CASHU") && (


Suggested change

{(info?.backendType === "LDK" || info?.backendType === "CASHU") && (

{(info?.backendType === "LDK" || info?.backendType === "CASHU" /* TODO: move to generic node command */) && (

We probably can wait for the generic node command feature to be merged and then undo this actually, then merge this PR

elnosh · 2025-01-15T16:39:44Z

https://8333.space:3338 which is operational (I can pay with my old balance) and I can send payments, but when I pay I get "no preimage in melt response". My balance then does not update after paying. Is this expected?

I've been testing with some mints (including that one) and I think that happens if you try to pay an invoice that was generated from that same mint. Looking at the response from the melt request, the payment is being settled and hence returning PAID but with an empty preimage and then making this check fail.

if meltResponse == nil || meltResponse.Preimage == "" {
	return nil, errors.New("no preimage in melt response")
}

I created issue for that here: cashubtc/nutshell#625
In other cases where I'm trying to pay a different lightning wallet or invoice from different mint, the preimage is there. Instead of checking the preimage we could check the melt state for "PAID" but not sure if you would want the empty preimage in those specific cases when it is returned empty.

elnosh · 2025-01-15T16:44:23Z

Restoring my sats on the old wallet with the incorrect balance changed it from 33 to 11 sats.

11 should be the correct balance given some previous payments?

With minibits I get the balance issue. I deposited 10 sats, then paid 1 sat. Now my balance is 12. Maybe just a calculation bug?

Sorry, I didn't understand this. Could you explain a bit further? You deposited 10 sats to an empty wallet set with minibits mint and got this?

rolznz · 2025-01-16T06:18:00Z

Sorry, I didn't understand this. Could you explain a bit further? You deposited 10 sats to an empty wallet set with minibits mint and got this?

Yes, I deposited 10 sats into an empty wallet with minibits mint.

Then I did a 1 sat payment to [email protected]. I guess the fee was 1 sat.

Instead of decreasing the balance to 8 sats (expected) it increased to 12 sats.

rolznz · 2025-01-16T06:19:18Z

I created issue for that here: cashubtc/nutshell#625 In other cases where I'm trying to pay a different lightning wallet or invoice from different mint, the preimage is there. Instead of checking the preimage we could check the melt state for "PAID" but not sure if you would want the empty preimage in those specific cases when it is returned empty.

It seems more than this - because in all my test payments I paid to my LDK hub node. I did not pay to the same mint.

rolznz · 2025-01-16T06:21:37Z

11 should be the correct balance given some previous payments?

I think so, yes. It just seems something is broken when we make payments, that the balance increases rather than decreases, or it does not omit already used cashu tokens

elnosh · 2025-01-16T14:11:39Z

Then I did a 1 sat payment to [email protected]. I guess the fee was 1 sat.
Instead of decreasing the balance to 8 sats (expected) it increased to 12 sats.

It seems more than this - because in all my test payments I paid to my LDK hub node. I did not pay to the same mint.

I haven't been able to replicate those issues :(

I've setup one with minibits mint and have been making payments fine (with preimage in the response). Sent to this address [email protected] and some other nodes and mints and balance has been updating correctly.

rolznz · 2025-01-17T05:21:46Z

I cannot figure out why mine is like this, I sent you my cashu wallet in case that helps you

update: maybe I was on the wrong branch or some other issue. I could not reproduce it a second time after re-checking out this branch and using a fresh work directory.

rolznz · 2025-01-18T07:16:37Z

frontend/src/lib/backendType.ts

@@ -33,7 +33,7 @@ export const backendTypeConfigs: Record<BackendType, BackendTypeConfig> = {
    hasNodeBackup: false,
  },
  CASHU: {
-    hasMnemonic: false,
+    hasMnemonic: true,


let's undo this one since the mnemonic is incompatible

rolznz · 2025-01-18T07:17:57Z

lnclient/cashu/cashu.go

 }

-func NewCashuService(workDir string, mintUrl string) (result lnclient.LNClient, err error) {
+func NewCashuService(cfg config.Config, workDir, encryptionKey, mintUrl string) (result lnclient.LNClient, err error) {


undo these changes as we will now return the mnemonic from a node command

rolznz · 2025-01-18T07:18:56Z

lnclient/cashu/cashu.go

@@ -231,6 +220,25 @@ func (cs *CashuService) RedeemOnchainFunds(ctx context.Context, toAddress string
 }

 func (cs *CashuService) ResetRouter(key string) error {
+	mnemonic := cs.wallet.Mnemonic()


for now we could check if key == "ALL" do the restore, otherwise get the mnemonic: cashuWallet.Mnemonic()

rolznz reviewed Jan 9, 2025

View reviewed changes

This was referenced Jan 9, 2025

Add general node command API endpoint that can be executed from settings -> debug tools #965

Open

build(deps): bump github.com/elnosh/gonuts from 0.2.0 to 0.3.0 #776

Closed

elnosh added 2 commits January 10, 2025 14:33

feat: update gonuts dependency

ddce78c

feat: restore cashu wallet from seed

c3c7f2c

elnosh force-pushed the update-gonuts branch from 73c3fa4 to c3c7f2c Compare January 10, 2025 19:46

Merge remote-tracking branch 'origin/master' into update-gonuts

db7cbb4

rolznz reviewed Jan 15, 2025

View reviewed changes

rolznz reviewed Jan 18, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update gonuts dependency #962

feat: update gonuts dependency #962

elnosh commented Jan 8, 2025

rolznz commented Jan 9, 2025

rolznz Jan 9, 2025

elnosh Jan 9, 2025

rolznz commented Jan 9, 2025

elnosh commented Jan 10, 2025

rolznz commented Jan 15, 2025

rolznz commented Jan 15, 2025 •

edited

Loading

rolznz commented Jan 15, 2025

rolznz Jan 15, 2025

rolznz Jan 15, 2025

elnosh Jan 15, 2025

rolznz Jan 16, 2025

elnosh Jan 16, 2025

rolznz Jan 17, 2025

elnosh Jan 17, 2025 •

edited

Loading

rolznz Jan 18, 2025

rolznz Jan 18, 2025

rolznz Jan 15, 2025

rolznz Jan 18, 2025

elnosh commented Jan 15, 2025

elnosh commented Jan 15, 2025 •

edited

Loading

rolznz commented Jan 16, 2025

rolznz commented Jan 16, 2025

rolznz commented Jan 16, 2025 •

edited

Loading

elnosh commented Jan 16, 2025

rolznz commented Jan 17, 2025 •

edited

Loading

rolznz Jan 18, 2025

rolznz Jan 18, 2025

rolznz Jan 18, 2025

	{(info?.backendType === "LDK" \|\| info?.backendType === "CASHU") && (
	{(info?.backendType === "LDK" \|\| info?.backendType === "CASHU" /* TODO: move to generic node command */) && (

feat: update gonuts dependency #962

Are you sure you want to change the base?

feat: update gonuts dependency #962

Conversation

elnosh commented Jan 8, 2025

rolznz commented Jan 9, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rolznz commented Jan 9, 2025

elnosh commented Jan 10, 2025

rolznz commented Jan 15, 2025

rolznz commented Jan 15, 2025 • edited Loading

rolznz commented Jan 15, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elnosh Jan 17, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elnosh commented Jan 15, 2025

elnosh commented Jan 15, 2025 • edited Loading

rolznz commented Jan 16, 2025

rolznz commented Jan 16, 2025

rolznz commented Jan 16, 2025 • edited Loading

elnosh commented Jan 16, 2025

rolznz commented Jan 17, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rolznz commented Jan 15, 2025 •

edited

Loading

elnosh Jan 17, 2025 •

edited

Loading

elnosh commented Jan 15, 2025 •

edited

Loading

rolznz commented Jan 16, 2025 •

edited

Loading

rolznz commented Jan 17, 2025 •

edited

Loading