Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display channel note above open channel buttons on increase incoming/outgoing flows #992

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Jan 14, 2025

This allows us to alert users of important info about certain channel partners. Shows on both incoming and outgoing flows.

image

The UI/UX could be improved, it's a bit difficult because by default the user is not informed of who they open a channel with unless they open the advanced options.

@rolznz rolznz requested review from bumi and reneaaron January 14, 2025 09:36
@bumi
Copy link
Contributor

bumi commented Jan 14, 2025

I am wondering if we should consider the on-chain channel open flow always "advanced" and show the "advanced options" by default?

@rolznz rolznz merged commit 3b78c6a into master Jan 17, 2025
10 checks passed
@rolznz rolznz deleted the feat/channel-note branch January 17, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants