Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: event emitter that works in browser #267

Merged
merged 2 commits into from
Nov 29, 2024
Merged

feat: event emitter that works in browser #267

merged 2 commits into from
Nov 29, 2024

Conversation

pavanjoshi914
Copy link
Contributor

No description provided.

Copy link

socket-security bot commented Nov 19, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@pavanjoshi914 pavanjoshi914 requested review from bumi and rolznz November 19, 2024 13:28
yarn.lock Show resolved Hide resolved
Copy link

socket-security bot commented Nov 20, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 46.6 kB sindresorhus

View full report↗︎

@bumi
Copy link
Contributor

bumi commented Nov 26, 2024

Does it work with the simple-boost button?

Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@pavanjoshi914
Copy link
Contributor Author

it does work.

image

also crossverified that I did yarn link correctly (I can see js SDK node_modules using emittery after yarn link
) so shall be good to go. we need to update js-sdk in bitcoin-connect and use new version of bitcoin-connect in simple boost

image

@bumi
Copy link
Contributor

bumi commented Nov 28, 2024

can you push the simple-boost with a git dependency to this one?

@rolznz
Copy link
Contributor

rolznz commented Nov 28, 2024

@pavanjoshi914 can you fix the conflict and merge it?

@pavanjoshi914
Copy link
Contributor Author

done

@pavanjoshi914 pavanjoshi914 merged commit 316fca4 into master Nov 29, 2024
3 checks passed
@pavanjoshi914 pavanjoshi914 deleted the emittery branch November 29, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants