Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add custom-timeout-values-for-requester-method #299

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: add custom-timeout-values-for-requester-method #299

wants to merge 3 commits into from

Conversation

Dayvvo
Copy link

@Dayvvo Dayvvo commented Jan 20, 2025

fixes #295

rolznz
rolznz reviewed Jan 21, 2025
View reviewed changes
src/NWCClient.ts
@@ -819,6 +825,7 @@ export class NWCClient {
nip47Method: Nip47SingleMethod,
params: unknown,
resultValidator: (result: T) => boolean,
timeoutValues?: Nip47TimeoutValues,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less important, but can this also be added to the executeMultiNip47Request method?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dayvvo what do you think about this one?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rolznz sounds good. Made a commit for that !!

rolznz
rolznz approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolznz rolznz rolznz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Dayvvo @rolznz