fix: remove kollider #2841
Merged
fix: remove kollider #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneaaron
force-pushed
the
fix/remove-kollider
branch
from
85cd853 to
a17498a
Compare
|
We can not do this, people currently might have accounts using it and for them the class would now be missing. We can remove it from the UI but the connector must stay there. |
|
Good point, we could also think about removing the connector config from the list of accounts, right? The check could potentially be done once after a version upgrade? (similar to DB migrations?) |
|
I would just keep the connector around but remove it from the UI where people can connect it. |
|
Good idea, thanks. Updated the PR and re-added the connector. 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
Fixes #2840