Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NIP44 Encryption Support #3075

Merged
merged 14 commits into from
Mar 13, 2024
Merged

NIP44 Encryption Support #3075

merged 14 commits into from
Mar 13, 2024

Conversation

pavanjoshi914
Copy link
Contributor

@pavanjoshi914 pavanjoshi914 commented Mar 11, 2024 •
edited
Loading

  1. NIP-44 encryption and decryption so that users can access nostr features built on the new primitives (derived from feat: add NIP 44 encryption support #2653)
  2. extract NIP44 into the extension itself until we update js-sdk to nostr 2.x

@pavanjoshi914 pavanjoshi914 changed the base branch from coracle-social/master to master March 11, 2024 08:09
@pavanjoshi914 pavanjoshi914 changed the title Merge pull request #2 from getAlby/fix/coracle-nip44 nip44 + drop nostr-tools Mar 11, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Mar 11, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@discoveryjs/[email protected] None 0 81.1 kB lahmatiy
npm/@noble/[email protected] None 0 611 kB paulmillr
npm/@webassemblyjs/[email protected] None +5 341 kB xtuc
npm/@webassemblyjs/[email protected] None +10 457 kB xtuc
npm/[email protected] None +3 98.1 kB doowb
npm/[email protected] environment, filesystem +13 502 kB paulmillr
npm/[email protected] None 0 11.4 kB feedic
npm/[email protected] None 0 22.8 kB doowb

🚮 Removed packages: npm/@noble/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

reneaaron
reneaaron approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the translations, otherwise:

utACK

src/i18n/locales/en/translation.json Outdated Show resolved Hide resolved
@pavanjoshi914 pavanjoshi914 changed the title nip44 + drop nostr-tools NIP44 Encryption Support Mar 11, 2024
@pavanjoshi914 pavanjoshi914 mentioned this pull request Mar 11, 2024
Closed
4 tasks
rolznz
rolznz approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@pavanjoshi914 pavanjoshi914 merged commit 1b31920 into master Mar 13, 2024
7 checks passed
@pavanjoshi914 pavanjoshi914 deleted the extract-nip44 branch March 13, 2024 11:14
@alexgleason
Copy link
Contributor

alexgleason commented May 21, 2024 •
edited
Loading

EDIT: I just saw it's already released, ignore me!

@pavanjoshi914
Copy link
Contributor Author

Yeah its already present in the production!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneaaron reneaaron reneaaron approved these changes

@rolznz rolznz rolznz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pavanjoshi914 @alexgleason @rolznz @reneaaron @staab