Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show pending and failed transactions for nwc #3292

Merged
merged 21 commits into from
Jan 23, 2025
Merged

feat: show pending and failed transactions for nwc #3292

merged 21 commits into from
Jan 23, 2025

Conversation

pavanjoshi914
Copy link
Contributor

@pavanjoshi914 pavanjoshi914 commented Dec 17, 2024 •
edited
Loading

show failed and pending transactions for nwc

Fixes #3291
Fixes #3299
image
image
image
image
image
image
image
image

@socket-security Socket Security
Copy link

socket-security bot commented Dec 17, 2024 •
edited
Loading

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@getalby/[email protected] 🔁 npm/@getalby/[email protected] None 0 206 kB rolznz
npm/@noble/[email protected] 🔁 npm/@noble/[email protected] None 0 611 kB paulmillr
npm/@noble/[email protected] 🔁 npm/@noble/[email protected] None 0 1.35 MB paulmillr
npm/[email protected] 🔁 npm/[email protected] None 0 46.6 kB sindresorhus
npm/[email protected] 🔁 npm/[email protected] None 0 3.33 MB fiatjaf
npm/[email protected] None 0 688 kB fiatjaf

🚮 Removed packages: npm/[email protected]

View full report↗︎

@pavanjoshi914 pavanjoshi914 marked this pull request as ready for review December 17, 2024 18:28
@pavanjoshi914 pavanjoshi914 requested review from reneaaron, rolznz and im-adithya and removed request for reneaaron, rolznz and im-adithya December 18, 2024 05:50
rolznz
rolznz reviewed Dec 18, 2024
View reviewed changes
src/common/utils/helpers.ts Outdated Show resolved Hide resolved
@pavanjoshi914 pavanjoshi914 requested a review from rolznz December 24, 2024 11:07
@rolznz rolznz requested a review from bumi January 2, 2025 04:51
@pavanjoshi914 pavanjoshi914 force-pushed the nwc-transaction-states branch from f245ef1 to c44add1 Compare January 2, 2025 13:52
@pavanjoshi914 pavanjoshi914 requested a review from rolznz January 9, 2025 17:33
@rolznz
Copy link
Contributor

rolznz commented Jan 10, 2025

I tested the nwc connector - failed and pending states look good 🙌

@pavanjoshi914 pavanjoshi914 requested a review from rolznz January 22, 2025 18:05
@pavanjoshi914
Copy link
Contributor Author

tACk

@pavanjoshi914 pavanjoshi914 merged commit c109f45 into master Jan 23, 2025
7 checks passed
@pavanjoshi914 pavanjoshi914 deleted the nwc-transaction-states branch January 23, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneaaron reneaaron Awaiting requested review from reneaaron

@im-adithya im-adithya Awaiting requested review from im-adithya

@bumi bumi Awaiting requested review from bumi

@rolznz rolznz Awaiting requested review from rolznz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update transaction icon colors [Feature] Show pending and failed transactions from the Hub
2 participants
@pavanjoshi914 @rolznz