fix api response codes if user is nil

getAlby · Dec 27, 2023 · 388dfcb · 388dfcb
1 parent 1935b0e
commit 388dfcb
Showing 1 changed file with 4 additions and 16 deletions.
diff --git a/echo_handlers.go b/echo_handlers.go
@@ -151,11 +151,7 @@ func (svc *Service) AppsShowHandler(c echo.Context) error {
 		})
 	}
 	if user == nil {
-		return c.JSON(http.StatusBadRequest, ErrorResponse{
-			Error:   true,
-			Code:    8,
-			Message: "User does not exist",
-		})
+		return c.NoContent(http.StatusUnauthorized)
 	}
 
 	app := App{}
@@ -236,11 +232,7 @@ func (svc *Service) AppsCreateHandler(c echo.Context) error {
 		})
 	}
 	if user == nil {
-		return c.JSON(http.StatusBadRequest, ErrorResponse{
-			Error:   true,
-			Code:    8,
-			Message: "User does not exist",
-		})
+		return c.NoContent(http.StatusUnauthorized)
 	}
 
 	name := c.FormValue("name")
@@ -367,16 +359,12 @@ func (svc *Service) AppsDeleteHandler(c echo.Context) error {
 		return err
 	}
 	if user == nil {
-		return c.JSON(http.StatusBadRequest, ErrorResponse{
-			Error:   true,
-			Code:    8,
-			Message: "User does not exist",
-		})
+		return c.NoContent(http.StatusUnauthorized)
 	}
 	app := App{}
 	svc.db.Where("user_id = ? AND nostr_pubkey = ?", user.ID, c.Param("pubkey")).First(&app)
 	svc.db.Delete(&app)
-	return c.JSON(http.StatusOK, "App deleted successfully")
+	return c.NoContent(http.StatusNoContent)
 }
 
 func (svc *Service) LogoutHandler(c echo.Context) error {