feat: add list transactions to nwc #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
Nov 23, 2023
rolznz
reviewed
Nov 23, 2023
rolznz
reviewed
Nov 23, 2023
rolznz
reviewed
Nov 23, 2023
lnd.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| resp, err := svc.client.ListInvoices(ctx, &lnrpc.ListInvoiceRequest{NumMaxInvoices: maxInvoices, IndexOffset: indexOffset}) |
There was a problem hiding this comment.
we still need to add support here for from, until, unpaid, is that right?
im-adithya
commented
Nov 23, 2023
rolznz
reviewed
Nov 24, 2023
rolznz
reviewed
Nov 24, 2023
rolznz
reviewed
Nov 28, 2023
service_test.go
Outdated
| func (mln *MockLn) LookupInvoice(ctx context.Context, senderPubkey string, paymentHash string) (invoice string, paid bool, err error) { | ||
| return mockInvoice, false, nil | ||
| } | ||
|
|
||
| func (mln *MockLn) ListInvoices(ctx context.Context, senderPubkey, from, until, limit, offset string) (invoices []*Invoice, err error) { |
There was a problem hiding this comment.
tests seem missing in this PR
im-adithya
changed the title
im-adithya
force-pushed
the
task-list-invoices
branch
from
a76658b to
8e51fe9
Compare
|
|
- unpaid check - decode bolt11 to add extra properties to payments - sort by created date desc
- fix optional transaction fields
…-response chore: update invoice functions to match NIP-46 extensions spec, fix optional transaction fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #175
Adds
list_transactionsmethod